Hey all. I'm a 20 year old male, 5"11, 165 Lbs. I've led a really unhealthy lifestyle the last 7 months i.e. Binge drinking every weekend, lots of fast food, no sport.

I joined a gym 2 weeks ago and improved my diet to get into shape. So far my routine consists of:

- 30 minutes of treadmill/crosstrainer
- 1 hour of doing all the upper body or lower body weights machines in the gym
- 10 minutes of rowing or 20 minutes of cycling

I go every day except sundays and alternate between upper body and lower body weights each day. I always choose 'random mode' on cycling/treadmill/crosstrainer. I'm usually really tired at the end of a workout.

I have a light breakfast at 10 every morning and a really healthy lunch at the cafeteria (lots of veg and fruit). I have no patience for cooking so for dinner I just buy a frozen meal which is usually pasta + sauce, moussaka (yum) or a random chinese dish. I also drink lots of water/tea during the day.

As far as I know, lots of time at gym and no alchohol/fast food = get into shape. Is there anything else I should or shouldn't be doing?

It is a decent start but you should get on a solid weight routine as opposed to just doing the machines. Is what your are doing balanced? Push vs Pull? Horizontal vs Vertical? A balanced routine compiled around mostly compound lifts is going to get you in better shape, faster.

also, always, ALWAYS, do weight training BEFORE cardio. Cardio will use stored fat OR stored glycogen for energy.
weight training can ONLY use stored glycogen. If you cardio first, you are cheating yourself out of a good weight workout.
If you lift weights first, you can deplete glycogen, leaving only stored fat for energy during the cardio.

Although ideally, you should do weights and cardio on separate days. piling more into a single workout session doesn't mean its better for you.