some one tell me if this routine is good for bulking up..

mon. chest tri's legs.
bench press 3x12 incline bench press 2x8 push ups
dips 3x15 tri' extension 3x12
squats 3x10 lunges 2x15

wed. bi's back shoulders.
preacher curls 2x12 hammer curls 2x12
chin ups 3x12 bent over rows 2x12
over head press 3x12 front raises 3x15 laterial raises 3x15

fri. chest shoulders back
bench press 3x12 incline bench press 2x8 push ups
over head press 3x12 front raises 3x15 laterial raises 3x15
chin ups 3x12 bent over rows 2x12
i also do some boxing on fridays


is there anything i should change or add...

you should isolate your muscle groups more. like do arms and shoulders one day then the next do chest back abs then the next do the lower body. that way you give your muscle groups plent of time to rest. also for better results try have a whey protein shake after a workout. and clean diet is probally the most important thing you can have for muscle growth.

I agree - having a split routine is best especially if you're lifting heavy. It allows your muscles to rest = grow. Perhaps do chest and tris one day, shoulders and abs one day, lower body one day, and bis and back another day.

Too much isolation work and you'd end up with overtrained shoulders, tri's and pecs if you're training to failure. This routine is less flashy but if you eat enough you should make better gains on it.

mon. chest tri's
bench press 5x5
military press 5x5
close grip bench 3x8

wed. bi's back
deadlift 5x5
bent over rows 5x5
barbell curls 3x8

fri. legs
squat 5x5
stiff legged deadlift 5x5
abs (ab pulldown) 3x8

how long should i rest between sets?

Two to four minutes, it isn't important as long as you've recovered enough to do the next set.